Skip to content

YARN-11913: Remove deprecated properties from yarn-default.xml#8149

Closed
cnauroth wants to merge 1 commit intoapache:trunkfrom
cnauroth:YARN-11913
Closed

YARN-11913: Remove deprecated properties from yarn-default.xml#8149
cnauroth wants to merge 1 commit intoapache:trunkfrom
cnauroth:YARN-11913

Conversation

@cnauroth
Copy link
Contributor

@cnauroth cnauroth commented Dec 29, 2025

Description of PR

Recent trunk changes now produce more assertive warnings about use of deprecated configuration properties. With some of these deprecated properties included in yarn-default.xml, that means every process launched logs the warnings. Remove them from core-default.xml to avoid these warnings. (Note that this does not take the step of actually removing the code that uses the deprecated properties. They'll continue to work. We just don't want warnings logged by default if the user didn't specifically use these properties.)

yarn application -list

2025-12-27 00:15:55,914 INFO Configuration.deprecation: yarn.resourcemanager.system-metrics-publisher.enabled in yarn-default.xml is deprecated. Instead, use yarn.system-metrics-publisher.enabled

How was this patch tested?

Build the distro:

mvn clean package -Pdist -Dtar -DskipTests

Verify the command above no longer produces deprecation warnings.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@cnauroth cnauroth mentioned this pull request Dec 29, 2025
Closed
1 task
@hadoop-yetus
Copy link

hadoop-yetus commented Dec 29, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 22m 25s trunk passed
+1 💚 compile 0m 29s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 26s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 mvnsite 0m 29s trunk passed
+1 💚 javadoc 0m 34s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 28s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 38m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 21s the patch passed
+1 💚 compile 0m 22s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 22s the patch passed
+1 💚 compile 0m 22s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 21s the patch passed
+1 💚 javadoc 0m 25s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 22s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 shadedclient 15m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 56s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
61m 45s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8149/1/artifact/out/Dockerfile
GITHUB PR #8149
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux f57f927cf15e 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 217d8cd
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8149/1/testReport/
Max. process+thread count 644 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8149/1/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cnauroth cnauroth mentioned this pull request Dec 29, 2025
Closed
4 tasks
@cnauroth
YARN-11913: Remove deprecated properties from yarn-default.xml
c2f01ae 
Closes apache#8149

Signed-off-by: Shilun Fan <slfan1989@apache.org>
@cnauroth
Copy link
Contributor Author

cnauroth commented Dec 29, 2025

I pushed up a new test to make sure there are no deprecated properties remaining in yarn-default.xml, similar to suggestions on #8148 .

@hadoop-yetus
Copy link

hadoop-yetus commented Dec 29, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
-1 ❌ mvninstall 22m 31s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 compile 0m 28s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 26s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 checkstyle 0m 19s trunk passed
+1 💚 mvnsite 0m 30s trunk passed
+1 💚 javadoc 0m 30s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 29s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 spotbugs 1m 4s trunk passed
+1 💚 shadedclient 14m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 20s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 21s the patch passed
+1 💚 compile 0m 22s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 11s the patch passed
+1 💚 mvnsite 0m 23s the patch passed
+1 💚 javadoc 0m 26s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 22s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 spotbugs 1m 0s the patch passed
+1 💚 shadedclient 14m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 50s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 23s The patch does not generate ASF License warnings.
65m 5s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8149/2/artifact/out/Dockerfile
GITHUB PR #8149
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux b3a940dc99f4 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c2f01ae
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8149/2/testReport/
Max. process+thread count 644 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8149/2/console
versions git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cnauroth
Copy link
Contributor Author

cnauroth commented Dec 29, 2025

The build failure is an unrelated pre-existing problem on trunk that I'm trying to fix in #8150 .

cnauroth
cnauroth commented Jan 2, 2026
View reviewed changes
Copy link
Contributor Author

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slfan1989 , are you also still +1 for this one too? This also has a new unit test added after your last review.

@slfan1989
Copy link
Contributor

slfan1989 commented Jan 3, 2026

@slfan1989 , are you also still +1 for this one too? This also has a new unit test added after your last review.

LGTM. Thanks for submitting this PR to address the issue!

@cnauroth cnauroth closed this in e842b60 Jan 5, 2026
@cnauroth
Copy link
Contributor Author

cnauroth commented Jan 5, 2026

I committed this to trunk. @slfan1989 and @aajisaka , thank you for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka approved these changes

@slfan1989 slfan1989 slfan1989 approved these changes

@steveloughran steveloughran Awaiting requested review from steveloughran

Assignees

No one assigned

Labels

trunk YARN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cnauroth @hadoop-yetus @slfan1989 @aajisaka